Daniel Bachhuber
jayabrack
Jeremy Felt
jtsternberg
Natebot
Nick Daugherty
Rinat KAd Code Manager v0.4.1 is out the door. Special thanks to @djpaulgibbs and @nickdaugherty for their contributions.
Hope to add basic tests and travis-ci integration today as a part of the pdxwp hack day.
Recent Updates Toggle Comment Threads | Keyboard Shortcuts
-
Daniel Bachhuber
-
Nick Daugherty
Created a pull request to add an ‘is_single’ filter (https://github.com/Automattic/Ad-Code-Manager/pull/68)
Merged by @rinatkhaziev in https://github.com/Automattic/Ad-Code-Manager/commit/c4b80c129bb5b6ebe3efcf0b9545d7ef1becb6b8 and pushed to WordPress.com by myself in r71715.
-
Daniel Bachhuber
-
Nick Daugherty
Done and done.
-
-
-
Paul Gibbs
Hi all,
On a dotcom site that uses Ad Code Manager, we’re seeing Google try to crawl ?preview= URLs (I have CSV reports from the site owner of the URLs that Google is failing to access). Not super sure how Google is finding those, but @danielbachhuber suggested it might be something like when an author is previewing a post, this triggers AdSense, AdSense reports back to Google the URL the code was triggered on, and Google tries to call it, and it errors.
If this sounds plausible, I’d like to suggest that adsense is disabled (i.e. not output) when is_preview() === true. ?
googletag.pubads().set(“page_url”, “URL”); is another option, but as page slugs/URLs may change during successive previews, invalid URLs might still occur.
-
Jeremy Felt
Also related – https://github.com/Automattic/Ad-Code-Manager/issues/40 – the previews that we want to provide in the admin dashboard itself may generate the same traffic.
Would it be hacky to use home_url() with the google.pubads().set() call whenever ( is_preview() === true OR is_admin() === true ) and then switch it to the published URL when it goes live?
-
Paul Gibbs
Or pass the post link as the ?p=123 version.
-
Daniel Bachhuber
Paul: I like that idea. Want to put together a pull request?
-
Paul Gibbs
Sure, will do today or tomorrow.
-
Paul Gibbs
Pull request is at https://github.com/Automattic/Ad-Code-Manager/pull/66
-
Paul Gibbs
Updated pull request for is_preview() approach per discussion on github
-
-
-
Daniel Bachhuber
I don’t have deep expertise with this. Has anyone hear of other clients reporting it?
-
Jeremy Felt
I just checked some webmaster tools stats and I don’t see any crawl errors for the custom doubleclick stuff that we’re doing. Maybe DFP async related? Our workflow more than likely doesn’t include a lot of preview views though either.
-
-
Rinat K
@danielbachhuber Toby with RedTri mentioned something about it.
-
-
Daniel Bachhuber
Shipped Ad Code Manager v0.4 last night, and announced today. It would be cool if we could get to everything in the v0.5 list by early May.
-
Jeremy Felt
Nice! I’m game with early May. I’ll tackle the prefilled conditionals stuff earlier than later so we can get some testing going on.
-
-
Daniel Bachhuber
… and I’m back into it. Let’s discuss a launch date for v0.4. I think the easy Google AdSense / Google DFP configuration is a good highlight feature.
@rinatkhaziev @jeremyfelt Of the other features we lined up for the milestone, is there anything you’d like to try to finish up before release?
I think two or three weeks from now would be a good date to hit.
-
Rinat K
@danielbachhuber I’ll try to tackle https://github.com/Automattic/Ad-Code-Manager/issues/40
-
Daniel Bachhuber
Great. Let’s plan on March 19th for now.
-
Jeremy Felt
March 19th is a good plan. I poked around last night to get refamiliar with things because it’s been a while.
I think it’s very feasible to have https://github.com/Automattic/Ad-Code-Manager/issues/42 in by then.
-
Glark
Sorry, I should have posted these on the support forums. Will do that now.
-
Daniel Bachhuber
Thanks!
-
-
-
Daniel Bachhuber
Well, we missed our Dec. 5th deadline for getting v0.4 out the door.
I’m going to allocate time next week for the configuration builder. How about we schedule for Dec. 20th?
-
Rinat K
Hey, I’m taking a vacay until 25th. After that I’m virtually slammed with q1 2013 work. I might be able to allocate some time to do preview and whatever I took responsibility for.
-
Daniel Bachhuber
Cool, no worries. Want to see if Jeremy or someone else wants to pick up your responsibilities if you can’t get to them?
-
-
Jeremy Felt
Womp womp.
I’m on a heavy deadline until the 21st, but I’m going to try to squeeze in some time between now and the 20th. Going to pause on #42 for a bit, because it’s dragging me down, but I’ll see what else I can clear up.
-
-
jtsternberg
Looking to update the ads via ajax, and stumbled onto the fact that the do_action will not work within an ajax call. Daniel reminded me that that is because the do_action() is dependent on the context (e.g. which post is loaded or the page that the ad is on). Would be great to be able to individually call (to update, or place the ad after the page has loaded) an ad code this way. Thoughts?
-
Rinat K
The workaround woud be to make a separate template with an ad code call and then just fetch the page with AJAX.
-
jtsternberg
But I would need the same conditionals to apply to this faux page that apply to the originating page. I.e. If I chose “is_home” as a conditional, and then reload the ads the way you’re suggesting, the same conditionals won’t apply (since a separate template is not, obviously, the home page). Am I missing something?
-
Rinat K
Well, nothing restricts you to add another conditional to home page ad tag that’ll match with this faux page. This approach is tested and works. The other way around would be calling the rendering method directly, but that probably wouldn’t work since there’s a bunch of hooks that are probably won’t get fired in AJAX context. Pull requests are always welcome
-
-
-
-
Daniel Bachhuber
v0.3 is out the door. Thanks again to @jtsternberg for his great contribution. In honor, I’ve given him push and pull access to our Github repo so he can help manage the project. Remember though: it never hurts to create a pull request to get another pair of eyes on your code before committing to master.
Any support for targeting Dec. 5th for a v0.4 release? Here’s what we have on the docket right now. I’m hoping to dive into the configuration builder/scanner tomorrow and through the weekend. Feel free to pick up any unclaimed issues.
-
jtsternberg
Awesome, thanks Daniel!
-
-
Daniel Bachhuber
Do you guys mind if I clean up and ship v0.3 today? Any unfinished code would go in v0.4
-
Jeremy Felt
Do it! I’m way behind on a bunch, so my updates won’t be for a week or two.
-
Rinat K
Go for it.
-
-
Daniel Bachhuber
Setting conditionals on a code by code basis was deployed to wpcom.
@rinatkhaziev which of the other open v0.3 issues do you think we should tackle before shipping? It might be nice to get this out on Friday.
-
Rinat K
I think preview for ad codes is the best candidate, since it’s been sitting there for too long.
https://github.com/Automattic/Ad-Code-Manager/issues/40-
Daniel Bachhuber
Do you have bandwidth for it?
-
-
Nick Daugherty and 
Thanks Nick! Btw, you should add yourself as an author on this site