Daniel Bachhuber
jayabrack
Jeremy Felt
jtsternberg
Natebot
Nick Daugherty
Rinat KFinished refactoring the WP List Table implementation this morning. Here’s what I’ve identified as needing work for v0.2:
- Updating the readme with information on what’s new and including screenshots
- Add “delete” icon and action for inline editing conditionals
- Testing
@jeremyfelt want to take a swing at updating the readme and including screenshots? @rinatkhaziev have time to start testing? I’m cool with releasing this as soon as I get the checkoffs from you guys 
Daniel Bachhuber 7:03 pm on April 30, 2012 Permalink |
Delete action and related styling is complete.
Rinat K 4:40 am on May 1, 2012 Permalink |
@danielbachhuber I made some changes to readme and added Configuration contextual help tab. I will mirror one of the sites tomorrow and have AdOps QA team to ensure that everything is ok. Probably we’ll need a simple migration function that’ll set priority to 10 for all ad codes (as v.0.1 doesn’t have permissions)
Daniel Bachhuber 2:24 pm on May 1, 2012 Permalink |
Sounds good. Re: priorities, the way the way the code should work is to have a priority of 10 if there is no priority set in the database. Saves us from having migrations
Rinat K 4:50 am on May 3, 2012 Permalink
I found a nasty thing during internal testing (not bring AdOps team yet). Marked it as #27 https://github.com/Automattic/Ad-Code-Manager/issues/27
Daniel Bachhuber 6:56 am on May 3, 2012 Permalink
That might be my fault… your comment looks good
Jeremy Felt 6:30 am on May 2, 2012 Permalink |
@danielbachhuber @rinatkhaziev I tweaked the Readme a little more and added several screenshots. Also addressed a minor PHP notice on a new install. Will continue testing tonight/tomorrow – things are looking good.
Daniel Bachhuber 4:10 pm on May 2, 2012 Permalink |
Great, thanks Jeremy.