Updates from April, 2012 Toggle Comment Threads | Keyboard Shortcuts

  • Daniel Bachhuber 6:00 pm on April 30, 2012 Permalink | Reply

    Finished refactoring the WP List Table implementation this morning. Here’s what I’ve identified as needing work for v0.2:

    @jeremyfelt want to take a swing at updating the readme and including screenshots? @rinatkhaziev have time to start testing? I’m cool with releasing this as soon as I get the checkoffs from you guys 🙂

  • Daniel Bachhuber 6:15 pm on April 26, 2012 Permalink | Reply

    Finishing up the inline editing implementation for the list table now… expect some refactoring.

    Can we open anything else that needs to be done as v0.2 issues? Goal is to be finished in the next few hours and then pass off to Rinat for testing. We can launch tomorrow or Monday.

  • Daniel Bachhuber 8:49 pm on April 20, 2012 Permalink | Reply
    Tags: support   

    First support question was posted!:

    How do ad-tags look like in my template or widget? What is Zone1? What does the ID do for me and how does it all fit together?

    Can you show us one example of how I would include a DFP tag? Let’s assume my account/slot values are ad-xxxxxxxxxxxx-0 and ad-xxxxxxxxxxxx-1, followed by /xxxxxx/AdUnit_Heaader_ATF_468x60 and /xxxxxx/AdUnit_Middle_ATF_300x250

    Now we have real users 🙂 Mark this moment in history. I’ll take a swing at replying to this.

    An easy way to keep track of new threads is by subscribing to the ad-code-manager tag.

  • Rinat K 9:24 pm on April 19, 2012 Permalink | Reply

    Good news, in addition to template tag now we also have a widget and a shortcode. Shortcode works like this: [acm-tag id=”your_tag_id”]

  • Rinat K 2:10 am on April 19, 2012 Permalink | Reply
    Tags: ,   

    Had some time today to remove jqGrid related code and add contextual help. Also added zztimur (our UX specialist) and jeremyfelt as contributors.

    There is a couple of things we need to do before tagging it 0.2:
    add/delete conditionals in “edit” row action
    delete action for ad codes

    • Jeremy Felt 6:33 am on April 19, 2012 Permalink | Reply

      @rinatkhaziev I can commit time to wrapping up the add/delete conditionals in the edit row and the delete action for ad codes at some point tomorrow. May be later in the day, but definitely doable.

    • Rinat K 5:07 am on April 20, 2012 Permalink | Reply

      @jeremyfelt well this is last thing that holding us off from tagging it v0.2. Good thing is that there should be only js related functionality on add/delete conditionals. I probably will have some time to implement mass delete action and factoring out 0.1.3 request handling tomorrow. Thanks a lot for your help!

      • Jeremy Felt 6:28 am on April 20, 2012 Permalink | Reply

        @rinatkhaziev – I just pushed the code for adding conditionals and allowing conditionals to be removed completely.

        That’s it for that pull request, so you’re clear if everything looks good. I’ll read through the documentation over the next few days as well.

    • Daniel Bachhuber 8:46 pm on April 20, 2012 Permalink | Reply

      Implemented some functionality to see the conditionals as the last column in the list table.

      There’s a bit to be desired with this implementation of WP List Table, so I’m going to commit a few improvements against this ticket. I also highly encourage you guys to open tickets for the things you’re working on… this helps tremendously in figuring out what changed when it comes time to testing and release notes.

      @jeremyfelt you’re now a committer to the repo. congrats 🙂

  • Daniel Bachhuber 9:23 pm on April 17, 2012 Permalink | Reply
    Tags: configuration, , usability   

    Quick thought to expand on: because the configuration process is someone involved, it would be nice if we auto-scanned what you’ve done so far and fired an admin notice if there’s anything incorrect about your configuration.

    • Rinat K 4:33 pm on April 18, 2012 Permalink | Reply

      good idea! also we can move quick start note to contextual help tab, and also expand UI help a bit.

  • Rinat K 5:41 pm on April 11, 2012 Permalink | Reply
    Tags: ,   

    Last night I committed more UI changes, however, still running late and won’t have any time today, probably. Any help with UI would be much appreciated.

    Here’s what’s left:
    Properly implement row actions
    Hook up AJAX editing actions for ad codes and conditionals
    When user adds ad code in the beginning, he could also add conditionals in one step. There’s a “Add more conditionals”, it should duplicate conditional.
    Minor css issues

  • Daniel Bachhuber 1:26 am on April 5, 2012 Permalink | Reply
    Tags: conditionals   

    In a recent commit, Rinat modifies the following code:

    // If the ad code doesn't have any conditionals
    // we should add it to the display list
    if ( empty( $ad_code['conditionals'] ) ) {
    	if ( $this->logical_operator == 'AND' ) {
    		$display_codes[] = $ad_code;


    // If the ad code doesn't have any conditionals
    // we should add it to the display list
    if ( empty( $ad_code['conditionals'] ) ) {
    	$display_codes[] = $ad_code;

    This means that each ad code will display on the site as soon as it’s added in the admin if it doesn’t have any conditionals applied. I think that this is probably a bad thing and that users will think it a bug as soon as we push the code that works “correctly”.

    Instead, we might do one or more things:

    1) Have an “ALL” logical operator which means that ad code are loaded regardless of conditionals. Something like:

    if ( empty( $ad_code['conditionals'] ) && $this->logical_operator == 'ALL' )

    2) Have ‘published’ vs. ‘draft’ states for ad codes that will allow some amount of pre-publication control.

    Thoughts? Feel free to weigh in before I create a ticket on this.

  • Rinat K 12:32 am on April 4, 2012 Permalink | Reply
    Tags: cache   


    I implemented cache in Ad_Code_Manager::get_ad_codes(), but cache keys are variables. That posed the following question: what’s the best strategy to clear the cache? We can’t just easily flush the whole ‘acm’ group. There is a couple of ways to do that, each with each own drawbacks:
    1. store keys as an option (but then you have to update it, whenever you add a new key)
    2. store keys as another cache key (but then it might expire)
    3. store keys as transient (not sure if it’s good from any POV)

    Any advice is much appreciated!

    • Daniel Bachhuber 12:16 am on April 5, 2012 Permalink | Reply

      I talked with Westi about this in IRC this morning. Basically, there are two options:

      1) Shorter timeouts
      2) Use an incrementer or cache version.

      For now, I think the easy, simple solution is to cache the get_ad_codes() query only when there aren’t any query args. This is the context we care most about caching (frontend page loads). What say you?

      • Rinat K 6:37 am on April 5, 2012 Permalink | Reply

        Makes sense, and then we just need to prime cache on ad code update.

Compose new post
Next post/Next comment
Previous post/Previous comment
Show/Hide comments
Go to top
Go to login
Show/Hide help
shift + esc