Updates from June, 2012 Toggle Comment Threads | Keyboard Shortcuts

  • Rinat K 4:55 am on June 27, 2012 Permalink | Reply

    0.3 Ideas Brainstorming Post 

    The 0.2 branch is looking good, so let’s talk 0.3. I recalled some ideas that were floating around since 0.1, but were never actualized:

    • Configuration scanner: verify configuration checklist ( provider file is present, ACM_WP_List_Table columns are properly defined, ad code args are set correctly, there’s at least one tag id, etc)
    • Ad Code Preview: This should be probably a row action which either pops an overlay with previews or displays them inline
    • Configuration builder: this one might be an overkill( aka punt candidate or fuggedaboutit), but it would be nice to have some tool that would generate configuration filters. Basic worklow would look like: user chooses one of existing ad providers, and modify some of default settings. For an average user, who downloaded plugin and who doesn’t know much about PHP coding, an ability to visually configure Β  stuff would come in handy.

    What do you think on these points? Do you have any other ideas/solutions? I personally appreciate the idea of keeping things contained and not over-bloated, but users get confused over configuration. I mean, one have to define 5-10 filters to get things up and running. Β This could be a deal-breaker for some folks.

    • Jeremy Felt 6:39 pm on June 27, 2012 Permalink | Reply

      I like the idea behind a configuration scanner / preview. I think it may be useful to combine those two and possibly some other data in some way as part of an add on for Debug Bar that is included with ACM. This may make it a lot easier to debug ad issues without having to dig through source, etc.

      The configuration builder does seem a bit overkill, but I do think we need an easier way to explain ACM to a new developer. I think I’ve tried 3 different approaches in our team now and it’s taken several conversations to get minds wrapped around how it works. The big question is how to quickly apply ACM to a non standard DFP configuration.

      From an end user perspective, it would be cool if we could modify the input fields for each conditional either through filters or just by default. For example – If is_category() is selected as the conditional, a drop down list of existing categories would be more pleasant than a text field.

    • Jeremy Felt 10:31 pm on June 27, 2012 Permalink | Reply

      Another idea that just came up – allowing for multiple providers to coexist on a page.

      It seems doable now if you know provider 1 will always display in the header and provider 2 will always display in the sidebar, but I can’t find a way to hook in via filter and change that based on an ad_code_arg to allow for complete flexibility for the user.

      • Daniel Bachhuber 10:37 pm on June 27, 2012 Permalink | Reply

        allowing for multiple providers to coexist on a page.

        This seems like an awesome improvement. File an issue πŸ™‚

    • Daniel Bachhuber 10:38 pm on June 27, 2012 Permalink | Reply

      I think a configuration scanner would be a great feature for v0.3. We could probably stick to one large feature per release to keep our release cycles reasonable (do what I say not what I do).

      • Rinat K 9:30 am on June 28, 2012 Permalink | Reply

        I went ahead and filed all the ideas. Feel free to tackle them πŸ˜€

    • David 9:01 am on September 18, 2012 Permalink | Reply

      Can I chime in here as a new to DFP (SB) and new to ACM user? It’s all confusing as hell. πŸ™‚

      Documentation, hand-holding and setup wizards would (I think) go a long way for better adoption. I’m trying to muddle my way through things with limited success. For example: what’s zone1? Never explained. It’s probably super-obvious to an experienced user but it’s never explicitly defined anywhere.

      All that said, this was/is obviously a lot of work so, thank you for creating it. If I can get this going I know it’ll make my life easier in the future.

      Where is the best place to post questions? Here, on the WP forum page?

  • Rinat K 4:08 am on June 27, 2012 Permalink | Reply

    Just tagged v0.2.3 on WPORG. Thanks y’all!

  • Daniel Bachhuber 11:56 pm on June 25, 2012 Permalink | Reply

    Synced over the extent of this commit to WordPress.com VIP (except the unit tests).

    If you could commit against an issue when you’re making improvements, it would be much appreciated. It’s much easier to refer to a series of commits this way πŸ™‚

    Thanks guys

    • Rinat K 4:25 am on June 26, 2012 Permalink | Reply

      @danielbachhuber I closed the outstanding issue and tagged 0.2.3 on github, wanted to push to WPORG but found out that I have no write privileges. So either give me a write or tag it yourself, please πŸ™‚

      • Daniel Bachhuber 7:30 pm on June 26, 2012 Permalink | Reply

        Sorry about that, I’ve given both you and @jeremyfelt commit access.

        When you tag the version, can you also remove the .js and .css files from jqGrid that are no longer in use? I’ve been unzipping the new version into the directory, which means changed files get updated and new files get added, but old files aren’t deleted…

        I’ve already removed the old files from the VIP repo.

        • Rinat K 8:44 pm on June 26, 2012 Permalink

          I found out that rsync comes in pretty handy in those situations

        • Rinat K 4:09 am on June 27, 2012 Permalink

          on the other hand, rm & svn rm are ok too πŸ™‚

        • Mo Jangda 4:11 am on June 27, 2012 Permalink

          rsync -rv --delete --exclude='.svn' /from /to
          cd /to
          svn status | grep '^!' | awk '{print $2}' | xargs svn rm
          svn status | grep '^?' | awk '{print $2}' | xargs svn add


        • Rinat K 4:14 am on June 27, 2012 Permalink

          Ha, glad that you’re still with us and thanks for the snippet πŸ™‚

        • Jeremy Felt 3:06 am on June 28, 2012 Permalink

          It should be known that Mo’s rsync comment made way for a beautiful addition to my local bash profile

  • Rinat K 7:21 pm on June 7, 2012 Permalink | Reply  

    Hey guys, there’s one issue left: https://github.com/Automattic/Ad-Code-Manager/issues/26

    What are your thoughts on it, @danielbachhuber, @jeremyfelt

  • Rinat K 7:02 am on June 7, 2012 Permalink | Reply  

    We have a test suite now 

    Hey guys,

    I made some basic test suite, it only has 5 tests now. It’s based on Nikolay’s wordpress-tests:Β https://github.com/nb/wordpress-tests. I also tackled the issue with ad_code_args. For some reason my comment is awaiting moderation, so Β I write a post instead.


    • Jeremy Felt 2:44 pm on June 7, 2012 Permalink | Reply

      Awesome! I’m diving in to the new branch now to check out the ad_codes_args stuff. Can’t wait to play with the test suite.

  • Daniel Bachhuber 9:28 pm on June 5, 2012 Permalink | Reply
    Tags: v0.2.2   

    Tagged and released v0.2.2 just now. Thanks for your help! I’ll put together a post for the publisher blog later today or tomorrow.

Compose new post
Next post/Next comment
Previous post/Previous comment
Show/Hide comments
Go to top
Go to login
Show/Hide help
shift + esc