Updates from Rinat K Toggle Comment Threads | Keyboard Shortcuts

  • Rinat K 10:38 pm on September 27, 2012 Permalink | Reply  

    While I was working on mobile theme for localtv I hit a bump with the following use case:
    Ad server returns a chunk of HTML instead of injecting script into DOM, I also couldn’t make it as iframe source, since it’s just a chunk instead of full HTML documents. This led to a hack that @batmoo qualified as “pretty lame”: I make an ajax request that passes constructed URL to ajax action, that fetches remote URL and returns this piece of HTML.

    Not sure of the best solution, perhaps, adding another hook like “acm_output_callback” or something like this.

  • Rinat K 4:55 am on June 27, 2012 Permalink | Reply

    0.3 Ideas Brainstorming Post 

    The 0.2 branch is looking good, so let’s talk 0.3. I recalled some ideas that were floating around since 0.1, but were never actualized:

    • Configuration scanner: verify configuration checklist ( provider file is present, ACM_WP_List_Table columns are properly defined, ad code args are set correctly, there’s at least one tag id, etc)
    • Ad Code Preview: This should be probably a row action which either pops an overlay with previews or displays them inline
    • Configuration builder: this one might be an overkill( aka punt candidate or fuggedaboutit), but it would be nice to have some tool that would generate configuration filters. Basic worklow would look like: user chooses one of existing ad providers, and modify some of default settings. For an average user, who downloaded plugin and who doesn’t know much about PHP coding, an ability to visually configure ย  stuff would come in handy.

    What do you think on these points? Do you have any other ideas/solutions? I personally appreciate the idea of keeping things contained and not over-bloated, but users get confused over configuration. I mean, one have to define 5-10 filters to get things up and running. ย This could be a deal-breaker for some folks.

    • Jeremy Felt 6:39 pm on June 27, 2012 Permalink | Reply

      I like the idea behind a configuration scanner / preview. I think it may be useful to combine those two and possibly some other data in some way as part of an add on for Debug Bar that is included with ACM. This may make it a lot easier to debug ad issues without having to dig through source, etc.

      The configuration builder does seem a bit overkill, but I do think we need an easier way to explain ACM to a new developer. I think I’ve tried 3 different approaches in our team now and it’s taken several conversations to get minds wrapped around how it works. The big question is how to quickly apply ACM to a non standard DFP configuration.

      From an end user perspective, it would be cool if we could modify the input fields for each conditional either through filters or just by default. For example – If is_category() is selected as the conditional, a drop down list of existing categories would be more pleasant than a text field.

    • Jeremy Felt 10:31 pm on June 27, 2012 Permalink | Reply

      Another idea that just came up – allowing for multiple providers to coexist on a page.

      It seems doable now if you know provider 1 will always display in the header and provider 2 will always display in the sidebar, but I can’t find a way to hook in via filter and change that based on an ad_code_arg to allow for complete flexibility for the user.

      • Daniel Bachhuber 10:37 pm on June 27, 2012 Permalink | Reply

        allowing for multiple providers to coexist on a page.

        This seems like an awesome improvement. File an issue ๐Ÿ™‚

    • Daniel Bachhuber 10:38 pm on June 27, 2012 Permalink | Reply

      I think a configuration scanner would be a great feature for v0.3. We could probably stick to one large feature per release to keep our release cycles reasonable (do what I say not what I do).

      • Rinat K 9:30 am on June 28, 2012 Permalink | Reply

        I went ahead and filed all the ideas. Feel free to tackle them ๐Ÿ˜€

    • David 9:01 am on September 18, 2012 Permalink | Reply

      Can I chime in here as a new to DFP (SB) and new to ACM user? It’s all confusing as hell. ๐Ÿ™‚

      Documentation, hand-holding and setup wizards would (I think) go a long way for better adoption. I’m trying to muddle my way through things with limited success. For example: what’s zone1? Never explained. It’s probably super-obvious to an experienced user but it’s never explicitly defined anywhere.

      All that said, this was/is obviously a lot of work so, thank you for creating it. If I can get this going I know it’ll make my life easier in the future.

      Where is the best place to post questions? Here, on the WP forum page?

  • Rinat K 4:08 am on June 27, 2012 Permalink | Reply

    Just tagged v0.2.3 on WPORG. Thanks y’all!

  • Rinat K 7:21 pm on June 7, 2012 Permalink | Reply  

    Hey guys, there’s one issue left: https://github.com/Automattic/Ad-Code-Manager/issues/26

    What are your thoughts on it, @danielbachhuber, @jeremyfelt

  • Rinat K 7:02 am on June 7, 2012 Permalink | Reply  

    We have a test suite now 

    Hey guys,

    I made some basic test suite, it only has 5 tests now. It’s based on Nikolay’s wordpress-tests:ย https://github.com/nb/wordpress-tests. I also tackled the issue with ad_code_args. For some reason my comment is awaiting moderation, so ย I write a post instead.


    • Jeremy Felt 2:44 pm on June 7, 2012 Permalink | Reply

      Awesome! I’m diving in to the new branch now to check out the ad_codes_args stuff. Can’t wait to play with the test suite.

  • Rinat K 9:24 pm on April 19, 2012 Permalink | Reply

    Good news, in addition to template tag now we also have a widget and a shortcode. Shortcode works like this: [acm-tag id=”your_tag_id”]

  • Rinat K 2:10 am on April 19, 2012 Permalink | Reply
    Tags: ,   

    Had some time today to remove jqGrid related code and add contextual help. Also added zztimur (our UX specialist) and jeremyfelt as contributors.

    There is a couple of things we need to do before tagging it 0.2:
    add/delete conditionals in “edit” row action
    delete action for ad codes

    • Jeremy Felt 6:33 am on April 19, 2012 Permalink | Reply

      @rinatkhaziev I can commit time to wrapping up the add/delete conditionals in the edit row and the delete action for ad codes at some point tomorrow. May be later in the day, but definitely doable.

    • Rinat K 5:07 am on April 20, 2012 Permalink | Reply

      @jeremyfelt well this is last thing that holding us off from tagging it v0.2. Good thing is that there should be only js related functionality on add/delete conditionals. I probably will have some time to implement mass delete action and factoring out 0.1.3 request handling tomorrow. Thanks a lot for your help!

      • Jeremy Felt 6:28 am on April 20, 2012 Permalink | Reply

        @rinatkhaziev – I just pushed the code for adding conditionals and allowing conditionals to be removed completely.

        That’s it for that pull request, so you’re clear if everything looks good. I’ll read through the documentation over the next few days as well.

    • Daniel Bachhuber 8:46 pm on April 20, 2012 Permalink | Reply

      Implemented some functionality to see the conditionals as the last column in the list table.

      There’s a bit to be desired with this implementation of WP List Table, so I’m going to commit a few improvements against this ticket. I also highly encourage you guys to open tickets for the things you’re working on… this helps tremendously in figuring out what changed when it comes time to testing and release notes.

      @jeremyfelt you’re now a committer to the repo. congrats ๐Ÿ™‚

  • Rinat K 5:41 pm on April 11, 2012 Permalink | Reply
    Tags: ,   

    Last night I committed more UI changes, however, still running late and won’t have any time today, probably. Any help with UI would be much appreciated.

    Here’s what’s left:
    Properly implement row actions
    Hook up AJAX editing actions for ad codes and conditionals
    When user adds ad code in the beginning, he could also add conditionals in one step. There’s a “Add more conditionals”, it should duplicate conditional.
    Minor css issues

  • Rinat K 12:32 am on April 4, 2012 Permalink | Reply
    Tags: cache   


    I implemented cache in Ad_Code_Manager::get_ad_codes(), but cache keys are variables. That posed the following question: what’s the best strategy to clear the cache? We can’t just easily flush the whole ‘acm’ group. There is a couple of ways to do that, each with each own drawbacks:
    1. store keys as an option (but then you have to update it, whenever you add a new key)
    2. store keys as another cache key (but then it might expire)
    3. store keys as transient (not sure if it’s good from any POV)

    Any advice is much appreciated!

    • Daniel Bachhuber 12:16 am on April 5, 2012 Permalink | Reply

      I talked with Westi about this in IRC this morning. Basically, there are two options:

      1) Shorter timeouts
      2) Use an incrementer or cache version.

      For now, I think the easy, simple solution is to cache the get_ad_codes() query only when there aren’t any query args. This is the context we care most about caching (frontend page loads). What say you?

      • Rinat K 6:37 am on April 5, 2012 Permalink | Reply

        Makes sense, and then we just need to prime cache on ad code update.

  • Rinat K 1:21 am on February 11, 2012 Permalink | Reply

    UI Facelift 

    Did a little bit of ui cleanup. Here’s before/after:

    Any feedback/suggestions on UI is much appreciated!

    • Daniel Bachhuber 1:07 am on February 14, 2012 Permalink | Reply

      Looks good! As a unfamiliar user, I think it would be great to eventually draw stronger connection between what you add in your templates, what you add in the “Ad Codes” table, what conditionals you include for each ad code, and then what the end result is.

      For instance, here are a few ideas that might help us get there:

      • In the right side of the page, list out the implementation steps one by one (much like we have in the readme)
      • Only show the conditionals table if one of the ad codes is selected. Also, the conditionals table could be on the right side at the same height as the ad code selected.
      • Show a live preview of the ad code when you have it selected.
      • Rinat K 1:22 am on February 14, 2012 Permalink | Reply

        Nice ideas, Only show the conditionals table if one of the ad codes is selected. – it’s already.
        The thing is both grids right next to each other is 1200px, may be we should make it responsive. Anyways, I booked our UI/UX guy to work with me on ACM this Wednesday

Compose new post
Next post/Next comment
Previous post/Previous comment
Show/Hide comments
Go to top
Go to login
Show/Hide help
shift + esc