Ad Code Manager v0.4.1 is out the door. Special thanks to @djpaulgibbs and @nickdaugherty for their contributions.
Hope to add basic tests and travis-ci integration today as a part of the pdxwp hack day.
Ad Code Manager v0.4.1 is out the door. Special thanks to @djpaulgibbs and @nickdaugherty for their contributions.
Hope to add basic tests and travis-ci integration today as a part of the pdxwp hack day.
Created a pull request to add an ‘is_single’ filter (https://github.com/Automattic/Ad-Code-Manager/pull/68)
Merged by @rinatkhaziev in https://github.com/Automattic/Ad-Code-Manager/commit/c4b80c129bb5b6ebe3efcf0b9545d7ef1becb6b8 and pushed to WordPress.com by myself in r71715.
Thanks Nick! Btw, you should add yourself as an author on this site 🙂
Done and done.
Hi all,
On a dotcom site that uses Ad Code Manager, we’re seeing Google try to crawl ?preview= URLs (I have CSV reports from the site owner of the URLs that Google is failing to access). Not super sure how Google is finding those, but @danielbachhuber suggested it might be something like when an author is previewing a post, this triggers AdSense, AdSense reports back to Google the URL the code was triggered on, and Google tries to call it, and it errors.
If this sounds plausible, I’d like to suggest that adsense is disabled (i.e. not output) when is_preview() === true. ?
googletag.pubads().set(“page_url”, “URL”); is another option, but as page slugs/URLs may change during successive previews, invalid URLs might still occur.
Also related – https://github.com/Automattic/Ad-Code-Manager/issues/40 – the previews that we want to provide in the admin dashboard itself may generate the same traffic.
Would it be hacky to use home_url() with the google.pubads().set() call whenever ( is_preview() === true OR is_admin() === true ) and then switch it to the published URL when it goes live?
Or pass the post link as the ?p=123 version.
Paul: I like that idea. Want to put together a pull request?
Sure, will do today or tomorrow.
Pull request is at https://github.com/Automattic/Ad-Code-Manager/pull/66
Updated pull request for is_preview() approach per discussion on github
I don’t have deep expertise with this. Has anyone hear of other clients reporting it?
I just checked some webmaster tools stats and I don’t see any crawl errors for the custom doubleclick stuff that we’re doing. Maybe DFP async related? Our workflow more than likely doesn’t include a lot of preview views though either.
@danielbachhuber Toby with RedTri mentioned something about it.
Reply